Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Addressing System.Runtime.Extensions failures #38996

Merged
merged 22 commits into from
Jul 13, 2020
Merged

[wasm] Addressing System.Runtime.Extensions failures #38996

merged 22 commits into from
Jul 13, 2020
+170 −123

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Jul 9, 2020 •
edited by akoeplinger
Loading

Contributes towards #38422
Fixes #38164
This PR looks to address test failures in System.Runtime.Extensions when running on Browser wasm.
Tests run: 6875, Errors: 0, Failures: 0, Skipped: 50. Time: 23.8534559s
This PR's changes will be integrated with changes related to environment which would account for the one failure and some skips. @steveisok

Failures

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@mdh1418 mdh1418 force-pushed the mdhwang/address_system_runtime_extensions_tests branch from 2e7ee4d to 6577263 Compare July 9, 2020 15:07
@mdh1418 mdh1418 force-pushed the mdhwang/address_system_runtime_extensions_tests branch from 6577263 to d6c4841 Compare July 9, 2020 15:29
@steveisok steveisok mentioned this pull request Jul 9, 2020
Closed
99 tasks
@marek-safar marek-safar mentioned this pull request Jul 10, 2020
Merged
@akoeplinger akoeplinger mentioned this pull request Jul 11, 2020
Merged
@jaredpar jaredpar mentioned this pull request Jul 13, 2020
Closed
@steveisok steveisok force-pushed the mdhwang/address_system_runtime_extensions_tests branch from 80c09c5 to c7343fa Compare July 13, 2020 16:32
@akoeplinger akoeplinger merged commit 927ced1 into dotnet:master Jul 13, 2020
@mdh1418 mdh1418 deleted the mdhwang/address_system_runtime_extensions_tests branch July 13, 2020 21:12
akoeplinger added a commit to akoeplinger/runtime that referenced this pull request Jul 29, 2020
@akoeplinger
[wasm] Remove unused icalls for Environment properties
2c2c29a 
They are no longer needed after dotnet#38996 since we return values in managed code now.
@akoeplinger akoeplinger mentioned this pull request Jul 29, 2020
Merged
@monojenkins monojenkins mentioned this pull request Jul 29, 2020
Merged
monojenkins pushed a commit to monojenkins/mono that referenced this pull request Jul 29, 2020
@akoeplinger
[wasm] Remove unused icalls for Environment properties
ffb03eb 
They are no longer needed after dotnet/runtime#38996 since we return values in managed code now.
marek-safar pushed a commit that referenced this pull request Jul 29, 2020
@akoeplinger
[wasm] Remove unused icalls for Environment properties (#40079)
bb82d67 
They are no longer needed after #38996 since we return values in managed code now.
akoeplinger added a commit to mono/mono that referenced this pull request Jul 29, 2020
@monojenkins @akoeplinger
[wasm] Remove unused icalls for Environment properties (#20180)
b258af8 
They are no longer needed after dotnet/runtime#38996 since we return values in managed code now.

Co-authored-by: akoeplinger <akoeplinger@users.noreply.github.com>
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@akoeplinger @Jacksondr5
[wasm] Remove unused icalls for Environment properties (dotnet#40079)
d311ae7 
They are no longer needed after dotnet#38996 since we return values in managed code now.
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveisok steveisok steveisok left review comments

@stephentoub stephentoub stephentoub left review comments

@jkotas jkotas jkotas left review comments

@marek-safar marek-safar marek-safar approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

@safern safern safern approved these changes

@MaximLipnin MaximLipnin Awaiting requested review from MaximLipnin

@jozkee jozkee Awaiting requested review from jozkee

@layomia layomia Awaiting requested review from layomia

@steveharter steveharter Awaiting requested review from steveharter

Assignees
No one assigned
Labels
area-System.Runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WASM] Environment.UserName raises "not supported" exception
8 participants
@mdh1418 @Dotnet-GitSync-Bot @marek-safar @steveisok @akoeplinger @stephentoub @jkotas @safern